Skip to content

Add support for fullscreen launchMode#6060

Merged
8 commits merged intomasterfrom
dev/migrie/f/288-launchMode-fullscreen
May 28, 2020
Merged

Add support for fullscreen launchMode#6060
8 commits merged intomasterfrom
dev/migrie/f/288-launchMode-fullscreen

Conversation

@zadjii-msft
Copy link
Copy Markdown
Member

@zadjii-msft zadjii-msft commented May 20, 2020 •
edited
Loading

Summary of the Pull Request

Adds "launchMode": "fullscreen", which does what it says on the box.

PR Checklist

Detailed Description of the Pull Request / Additional comments

It's important to let the winow get created, then fullscreen it, because otherwise, when the user exits fullscreen, the window is sized to like, 0x0 or something, and that's just annoying.

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 20, 2020
tikkss added a commit to tikkss/dotfiles that referenced this pull request May 21, 2020
@tikkss
Modify launch mode is maximized for Windows Terminal
a85309e 
本当はフルスクリーンモードが良いが（タブの表示領域が不要なので）
現状、フルスクリーンモードの設定がない。

プルリクエストは出されているようなので、とりあえず最大化で凌ぐことにした。

[Add support for fullscreen `launchMode` by zadjii-msft · Pull Request #6060 · microsoft/terminal · GitHub](microsoft/terminal#6060)
carlos-zamora
carlos-zamora requested changes May 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve, but there's a lot of changed to the vcxproj files that got committed. Should we pull those out?

Comment thread src/cascadia/WindowsTerminal/IslandWindow.cpp
}

ShowWindow(_window.get(), nCmdShow);

Copy link
Copy Markdown
Member

@carlos-zamora carlos-zamora May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you could probably remove this change

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 21, 2020
@zadjii-msft
Copy link
Copy Markdown
Member Author

zadjii-msft commented May 21, 2020

there's a lot of changed to the vcxproj files that got committed. Should we pull those out?

shit absolutely, I didn't realize I was on 16.6 when I committed/pushed this branch 😬

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 21, 2020
@zadjii-msft zadjii-msft requested a review from carlos-zamora May 21, 2020 21:22
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label May 21, 2020
@ghost ghost requested review from leonMSFT and miniksa May 21, 2020 21:22
DHowett
DHowett approved these changes May 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Make sure the drag bar doesn't exist when you start this way!

@zadjii-msft zadjii-msft mentioned this pull request May 22, 2020
Merged
3 tasks
@zadjii-msft
Copy link
Copy Markdown
Member Author

zadjii-msft commented May 27, 2020

@carlos-zamora unblock me pls 😄

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 27, 2020
@ghost
Copy link
Copy Markdown

ghost commented May 27, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 807d2cf into master May 28, 2020
@ghost ghost deleted the dev/migrie/f/288-launchMode-fullscreen branch May 28, 2020 16:53
@zadjii-msft zadjii-msft restored the dev/migrie/f/288-launchMode-fullscreen branch May 28, 2020 17:00
jelster pushed a commit to jelster/terminal that referenced this pull request May 28, 2020
@zadjii-msft @jelster
Add support for fullscreen launchMode (microsoft#6060)
0d8bb2c 
## Summary of the Pull Request

Adds `"launchMode": "fullscreen"`, which does what it says on the box.

## PR Checklist
* [x] Closes microsoft#288
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

It's important to let the winow get created, _then_ fullscreen it, because otherwise, when the user exits fullscreen, the window is sized to like, 0x0 or something, and that's just annoying.
ghost pushed a commit that referenced this pull request Jun 1, 2020
@zadjii-msft
Add support for --fullscreen, --maximized (#6139)
8987486 
## Summary of the Pull Request

Adds two new flags to the `wt.exe` alias:

* `--maximized,-M`: Launch the new Terminal window maximized. This flag cannot be combined with `--fullscreen`.
* `--fullscreen,-F`: Launch the new Terminal window fullscreen. This flag cannot be combined with `--maximized`.

## References
* This builds on the work done in #6060.
* The cmdline args megathread: #4632

## PR Checklist
* [x] Closes #5801
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

* I had to move the commandline arg parsing up a layer from `TerminalPage` to `AppLogic`, because `AppLogic` controls the Terminal's settings, including launch mode settings. This seems like a reasonable change, to put both the settings from the file and the commandline in the same place.
  - **Most of the diff is that movement of code**

* _"What happens when you try to pass both flags, like `wtd -M -F new-tab`?"_:
![image](https://user-images.githubusercontent.com/18356694/82679939-3cffde00-9c11-11ea-8d88-03ec7db83e59.png)

## Validation Steps Performed
* Ran a bunch of commandlines to see what happened.
This was referenced Jun 12, 2020
Closed
Merged
@ghost
Copy link
Copy Markdown

ghost commented Jun 18, 2020 •
edited by miniksa
Loading

🎉Windows Terminal Preview v1.1.1671.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 18, 2020
Closed
@DHowett DHowett deleted the dev/migrie/f/288-launchMode-fullscreen branch October 26, 2021 16:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees

No one assigned

Labels

Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Setting] Option to launch already maximized / fullscreen

3 participants

@zadjii-msft @DHowett @carlos-zamora
⚡